Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File closer enhancement (important) #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

File closer enhancement (important) #37

wants to merge 1 commit into from

Conversation

jeevatkm
Copy link
Contributor

@jeevatkm jeevatkm commented Mar 22, 2017 •
edited
Loading

@brettlangdon Thanks for #36 and this PR is complement to that and improvement.

  • To ensure to close the file after parsing

Please have a look and accept :)

@jeevatkm
Copy link
Contributor Author

It seems go1.5 build fails due to dependencies.

@jeevatkm
Copy link
Contributor Author

@brettlangdon Whenever you get a chance, merge this PR. It basically closes the opened config file after processing. Since defer close call removed as part of this commit c9dd35b for fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeevatkm