Skip to content

Commit

Permalink
fix(internal/secrets): Error on Missing Secrets (#260)
Browse files Browse the repository at this point in the history
  • Loading branch information
jshlbrd authored Oct 10, 2024
1 parent c9947dd commit b788992
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions internal/secrets/secrets.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ var (
// interpRe is used for parsing secrets during interpolation. Secrets
// must not contain any curly braces.
interpRe = regexp.MustCompile(`\${(SECRET:[^}]+)}`)
// errNoSecret is returned when no secrets are found in the cache.
errNoSecret = fmt.Errorf("secrets: no secret found")
// KV store is used as a secrets cache
cache kv.Storer
)
Expand Down Expand Up @@ -72,6 +74,10 @@ func Interpolate(ctx context.Context, s string) (string, error) {
return "", err
}

if secret == nil {
return "", errNoSecret
}

// Replaces each substring with a secret. If the secret is
// BAR and the string was "/path/to/secret/${SECRET:FOO}",
// then the interpolated string output is "/path/to/secret/BAR".
Expand Down

0 comments on commit b788992

Please sign in to comment.