Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new races from 7.3.5 & Partial support in BFA for Azerite #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added new races from 7.3.5 & Partial support in BFA for Azerite #93

wants to merge 4 commits into from

Conversation

jsassner
Copy link
Contributor

No description provided.

mjdean1994
mjdean1994 reviewed Jan 31, 2018
View reviewed changes
Copy link

@mjdean1994 mjdean1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mean to be pedantic, but the tabbing is off for added races. Doesn't seem like a big ask for the sake of code readability.

@LairdStreak
Copy link
Collaborator

Please could you tidy up indenting not only in Explorers/Models/Character.cs but also in Explorers.Test/GuildTests.cs Makes it easier for others.

LairdStreak
LairdStreak approved these changes Jan 31, 2018
View reviewed changes
Copy link
Collaborator

@LairdStreak LairdStreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Merge at your discretion.

@jsassner jsassner changed the title Added new races from 7.3.5 Added new races from 7.3.5 & Partial support in BFA for Azerite Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjdean1994 mjdean1994 mjdean1994 left review comments

@LairdStreak LairdStreak LairdStreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsassner @LairdStreak @mjdean1994