Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MIPS 32-bit big-endian #1894

Closed

Conversation

DavidHorton5339
Copy link
Contributor

Now that ring has generic fallback code, we can compile it for new targets by allowing them through target.h checks.
I'd like to add MIPS support. This works well (all unit tests pass, and our application works on the target).
Unfortunately the Rust compiler recently got broken for MIPS, so version 1.71 or earlier is required.
Same as #1859, but without the unsquashable multiple commits over > 1 branch.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3fda8b) 96.00% compared to head (6ce9f07) 96.02%.
Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
+ Coverage   96.00%   96.02%   +0.01%     
==========================================
  Files         138      136       -2     
  Lines       20746    20776      +30     
  Branches      226      226              
==========================================
+ Hits        19918    19950      +32     
- Misses        790      792       +2     
+ Partials       38       34       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith
Copy link
Owner

My understanding is that this target basically wouldn't work in Rust 1.72 or later without a self-built toolchain? Is that right?

@briansmith
Copy link
Owner

@DavidHorton5339 I am closing this in favor of #1910, which rebases this PR on top of the latest changes to main and adds this and mipsel to the CI test matrix.

@briansmith briansmith closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants