Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Add generalized "noinline" attribute support. #1898

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

briansmith
Copy link
Owner

There are some functions that we never want to be (cross-language) inlined, and we expect to add more. Make it easier to add more, and make it easier to extend this capability to more C compilers.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4742e0) 96.02% compared to head (1cf34e0) 96.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1898   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         136      136           
  Lines       20776    20776           
  Branches      226      226           
=======================================
  Hits        19950    19950           
  Misses        792      792           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There are some functions that we never want to be (cross-language)
inlined, and we expect to add more. Make it easier to add more, and
make it easier to extend this capability to more C compilers.
@briansmith
Copy link
Owner Author

The original submission of this PR used standard attirbute syntax [[clang::noinline]] when compiling with clang. But, apparently clang doesn't like mixing __attribute__((...)) syntax with the standard attribute syntax, which was being done in the ADX code. So, I change RING_NOINLINE to use __attribute__((...)) syntax for clang too.

@briansmith briansmith merged commit a0ce2d3 into main Jan 13, 2024
140 checks passed
@briansmith briansmith deleted the b/noinline branch January 13, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant