-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use llvm-tools-preview instead of external llvm-tools for symbol prefix testing #1908
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1908 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 136 136
Lines 20776 20776
Branches 226 226
=======================================
Hits 19950 19950
Misses 792 792
Partials 34 34 ☔ View full report in Codecov by Sentry. |
https://github.com/briansmith/ring/actions/runs/7515538763/job/20459551889 is a run that intentionally breaks symbol prefixing, to test this. |
f9e33e5
to
f3ee283
Compare
It looks like the Windows builds are using PowerShell to run the shell script, and "passing" even though they aren't doing any work. :( I'll need to update this to force the use of mingw bash for windows. |
b1de080
to
4166c29
Compare
Well, after that, it seems more work is needed for Windows. Will split the Windows work off into a separate issue/PR. |
https://github.com/briansmith/ring/actions/runs/7516068245 is the new test run to make sure CI fails when an unprefixed symbol exists. |
It doesn't seem to work with the 1.61.0 toolchain for iOS, so exclude that.
4166c29
to
3cb66f5
Compare
https://github.com/briansmith/ring/actions/runs/7516194196 was the final test run that shows that the builds break when there is an unprefixed symbol. |
See individual commit messages for details. This makes the script portable to all hosts and allows us to expand the symbol prefix checking to all tested targets. It also allows us to avoid incompatibilities between Apple nm and the toolchain's output.