Enable SHA512 acceleration on Aarch4 Android, Linux, and Apple targets. #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
==========================================
- Coverage 96.29% 96.28% -0.01%
==========================================
Files 136 137 +1
Lines 20677 20723 +46
Branches 226 226
==========================================
+ Hits 19910 19954 +44
- Misses 732 735 +3
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/sha512-apple-2
branch
11 times, most recently
from
cc782fe to
87b7687
Compare
briansmith
force-pushed
the
b/sha512-apple-2
branch
3 times, most recently
from
75d071b to
41651bc
Compare
briansmith
commented
Mar 2, 2024
| } | ||
| debug_assert_eq!(len, mem::size_of_val(&value)); | ||
| if len != mem::size_of_val(&value) { | ||
| return false; |
There was a problem hiding this comment.
Hmm...why is codecov telling me that this line is being hit?
| let rc = unsafe { libc::sysctlbyname(name, value_ptr, &mut len, core::ptr::null_mut(), 0) }; | ||
| // All the conditions are separated so we can observe them in code coverage. | ||
| if rc != 0 { | ||
| return false; |
There was a problem hiding this comment.
I don't understand why codecov is saying this is being hit.
briansmith
force-pushed
the
b/sha512-apple-2
branch
2 times, most recently
from
1bb7778 to
5cd744a
Compare
briansmith
commented
Mar 2, 2024
| fn getauxval(type_: c_ulong) -> c_ulong; | ||
| cfg_if::cfg_if! { | ||
| if #[cfg(target_arch = "aarch64")] { | ||
| use libc::{getauxval,AT_HWCAP, HWCAP_AES, HWCAP_PMULL, HWCAP_SHA2, HWCAP_SHA512}; |
Tested on M1 and time consumed by sha512 is reduced to half.
Make it easy to test the dynamic detection for other aarch64-apple-* targets.
Use the `libc` crate so we don't have to maintain the binding for `sysctlbyname`, and so `libc` will take care of the linking to libc as needed.. Wrap `sysctlbyname` in a safe wrapper. Separate the branches for the `sysctlbyname` results so we can see them individually in code coverage.
briansmith
force-pushed
the
b/sha512-apple-2
branch
from
5cd744a to
49add64
Compare
BusyJay
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.