Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker environment #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kolyunya
Copy link
Contributor

@Kolyunya Kolyunya commented Jan 6, 2021

This should make the development of the library much much easier.

There will be no need to install any services locally.

This can also potentially simplify the CI configuration.

Only PostgreSQL is currently supported in this proof of concept version.

@BenMorel BenMorel force-pushed the master branch 2 times, most recently from 3918a75 to 69e9bb2 Compare March 14, 2021 11:39
@BenMorel
Copy link
Member

Hi, thanks for your PR. I'm trying it out but getting an error:

$ docker-compose up --detach

ERROR: The Compose file './docker-compose.yml' is invalid because:
networks.network value Additional properties are not allowed ('name' was unexpected)
volumes.postgres value Additional properties are not allowed ('name' was unexpected)

Any idea what's wrong? I'm using docker 19.03.6 and docker-compose 1.25.5.

@Kolyunya
Copy link
Contributor Author

@BenMorel well, this obviously has to do with the docker-compose version. We probably should try to support as many of old versions as we could. So I'm going to check how we can refactor the config without using name properties.

@Kolyunya
Copy link
Contributor Author

@BenMorel can you try the new config version? I've removed name properties altogether.

@BenMorel BenMorel force-pushed the master branch 9 times, most recently from e672ec6 to 47bdb4e Compare October 14, 2022 20:56
@BenMorel BenMorel force-pushed the master branch 2 times, most recently from 4f4bb6e to ce4503f Compare November 21, 2022 23:44
@BenMorel BenMorel force-pushed the master branch 2 times, most recently from bcc19f3 to 0ba1296 Compare August 19, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants