Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore single quotes around 'EOF' #15

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Restore single quotes around 'EOF' #15

merged 2 commits into from
Apr 16, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Apr 16, 2024

I made a mistake while merging two recent PRs. #14 needed these single quotes around 'EOF' to allow the $ in some Zeek script code to make its way into the output, whereas #13 did not need that treatment. There was a merge conflict between the two, so when resolving that I accidentally took the variant without the single quotes, so I caught my mistake when verifying the final changes on tip of main. Fixing that here.

@philrz philrz self-assigned this Apr 16, 2024
@philrz philrz requested review from nwt and mattnibs April 16, 2024 18:15
@philrz philrz merged commit dc10ee9 into main Apr 16, 2024
0 of 3 checks passed
@philrz philrz deleted the eof-single-quotes branch April 16, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants