-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static libraries #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c8e3e1.
philrz
commented
Jan 6, 2024
philrz
commented
Jan 6, 2024
nwt
approved these changes
Jan 7, 2024
Co-authored-by: Noah Treuhaft <[email protected]>
Co-authored-by: Noah Treuhaft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting a previous artifact built from this repo, @nwt spotted some dynamic library dependencies that had not been there in our v3.2.1-brim10 artifact that's been in use for years. To minimize the chance of new issues among users, this PR makes makes sure we link to the static libraries in all those cases.
Using the latest artifact built from this branch, proof is provided below that compares vs. v3.2.1-brim10.
macOS
tl;dr - The dynamic library dependencies are the same as before.
Windows
tl;dr -
PSAPI.DLL
is no longer a dependency.CRYPT32.dll
is a new dependency and appears legit.Linux
tl;dr - The dynamic library dependencies are the same as before.