Add workaround for zeek/3534 on Windows #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
approved these changes
Jan 16, 2024
Co-authored-by: Noah Treuhaft <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeek/zeek#3534 was the one open issue that was holding me back from packaging a Zeek v6 artifact with Zui. That's now spawned follow-on issue mheily/libkqueue#155 and based on the lack of activity in that libkqueue repo I don't have much faith a fix is coming any time soon. Therefore it seems it's time to make a call on going ahead with shipping a Zeek v6 artifact that disables the packages that are known to trigger that segfault.
The changes in this branch comment out the
@loadof the two packages that trigger the bad code path as part of the bundling of the Windows artifact. I've made a test Zeek artifact v6.2.0-brim-dev2 based on that and referenced that in test Brimcap artifact v1.6.0-alpha4 and then referenced that Brimcap artifact from the Zui dev build from Actions run https://github.com/brimdata/zui/actions/runs/7534518094. With that Zui I've confirmed that the wrccdc 2018 pcaps that formerly triggered the segfault can loaded into that Zui without error. I've also done side-by-side drags of the 4 GB "all.pcap" and confirmed we see the expected delta innoticeevents based on the disabling of thedetect-MHRpackage in the Windows case.macOS
Windows