-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4 #235
base: main
Are you sure you want to change the base?
Conversation
That's great and thanks for new version with great changes Do you have a plan to put RTL support in this version |
@mohsenomidi yes, the next version will support RTL. |
Dear @jameskerr Thanks for this PR. We are exciting to have the features in i this PR, do you have any plans to merge the changes 🙏 |
I'd be interested about your current status, any blockers still open? |
Hello @jameskerr thanks for the update in #275. I had a few thoughts on finishing version 4, you have already done a LOT of work on the new version. Would that be enough to constitute a v4 release? The drop cancel issue I see you fixed as well (we fixed this recently ourselves also). What else would you want for a v4 or if this is enough would it just be migration that needs to be written? // Ben |
@ben-hearn-sb I do need some sort of migration guide. I would also like a compatibility component so it doesn't completely break if people upgrade. For example, the <Tree/ > component is what is used in v3. I removed in favor of component is the upgraded component for v4. I would like to add back to v4, make all the props compatible with v3, but in the body of the component just re-write the props and give them to . If you'd be interested in helping write that I would welcome it! |
Experimenting with what the next iteration of the react-arborist api will be, while maintaining all backward compatibility.
Remaining Items