Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4 #235

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Version 4 #235

wants to merge 43 commits into from

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Mar 13, 2024

Experimenting with what the next iteration of the react-arborist api will be, while maintaining all backward compatibility.

Remaining Items

  • node.state
  • require props hook
  • disable drop function
  • sort nodes
  • filter nodes
  • customizable commands object
  • fix weird cursor positions
  • outside drop
  • compatibility layer with props
  • Make it with with no props
  • provide way to disable features
  • RTL support
  • Variable height rows
  • Scrolling callbacks
  • Open all folders when filtering
  • Open folder when dropping into it
  • Open folder when hovering over it for a time
  • Custom Renderers
  • Two Tree Demo
  • Checkbox Demo
  • Everything is a folder Demo
  • Drag Handle
  • Duplicate Nodes
  • Trag between trees
  • Checkbox Demo
  • All Internal Demo
  • RTL Demo
  • Different Drag Previews
  • selectionFollowsFocus Demo
  • Use Single Selection

@jameskerr jameskerr changed the title Nodes Partial Controller Version 4 Mar 19, 2024
@mohsenomidi
Copy link

@jameskerr

That's great and thanks for new version with great changes

Do you have a plan to put RTL support in this version

@jameskerr
Copy link
Member Author

@mohsenomidi yes, the next version will support RTL.

@mohsenomidi
Copy link

Dear @jameskerr

Thanks for this PR.

We are exciting to have the features in i this PR, do you have any plans to merge the changes

🙏

@CHE1RON
Copy link

CHE1RON commented Aug 4, 2024

I'd be interested about your current status, any blockers still open?

@ben-hearn-sb
Copy link

Hello @jameskerr thanks for the update in #275.

I had a few thoughts on finishing version 4, you have already done a LOT of work on the new version. Would that be enough to constitute a v4 release? The drop cancel issue I see you fixed as well (we fixed this recently ourselves also).

What else would you want for a v4 or if this is enough would it just be migration that needs to be written?

// Ben

@jameskerr
Copy link
Member Author

@ben-hearn-sb I do need some sort of migration guide. I would also like a compatibility component so it doesn't completely break if people upgrade.

For example, the <Tree/ > component is what is used in v3.

I removed in favor of component is the upgraded component for v4.

I would like to add back to v4, make all the props compatible with v3, but in the body of the component just re-write the props and give them to .

If you'd be interested in helping write that I would welcome it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants