Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding minimal required readme instructions #278

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

AndrewRayCode
Copy link
Contributor

@AndrewRayCode AndrewRayCode commented Oct 12, 2024

The readme, very strangely(!) does not include how to load react-arborist. VSCode intellisense is not able to locate where to get <Tree> from, at least when I tried it after a fresh install.

README.md Outdated
@@ -31,7 +31,7 @@ yarn add react-arborist
```

```
npm install react-arborist
npm install --save react-arborist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change and we can merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jameskerr jameskerr merged commit 86e9036 into brimdata:main Dec 3, 2024
1 check passed
@jameskerr
Copy link
Member

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants