Fix sort return args (#5310)

brimdata · Sep 30, 2024 · 402bd93 · 402bd93
1 parent 7472e49
commit 402bd93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/compiler/kernel/vop.go b/compiler/kernel/vop.go
@@ -111,11 +111,7 @@ func (b *Builder) compileVamLeaf(o dag.Op, parent vector.Puller) (vector.Puller,
 			}
 			sortExprs = append(sortExprs, samexpr.NewSortEvaluator(k, s.Order))
 		}
-		sort, err := vamop.NewSort(b.rctx, parent, sortExprs, o.NullsFirst, o.Reverse, b.resetters)
-		if err != nil {
-			return nil, fmt.Errorf("compiling sort: %w", err)
-		}
-		return sort, nil
+		return vamop.NewSort(b.rctx, parent, sortExprs, o.NullsFirst, o.Reverse, b.resetters), nil
 	case *dag.Rename:
 		srcs, dsts, err := b.compileAssignmentsToLvals(o.Args)
 		if err != nil {

diff --git a/runtime/vam/op/sort.go b/runtime/vam/op/sort.go
@@ -19,13 +19,10 @@ type Sort struct {
 	samsort *sort.Op
 }
 
-func NewSort(rctx *runtime.Context, parent vector.Puller, fields []expr.SortEvaluator, nullsFirst, reverse bool, resetter expr.Resetter) (*Sort, error) {
+func NewSort(rctx *runtime.Context, parent vector.Puller, fields []expr.SortEvaluator, nullsFirst, reverse bool, resetter expr.Resetter) *Sort {
 	materializer := vam.NewMaterializer(parent)
-	s, err := sort.New(rctx, materializer, fields, nullsFirst, reverse, resetter)
-	if err != nil {
-		return nil, err
-	}
-	return &Sort{rctx: rctx, samsort: s}, nil
+	s := sort.New(rctx, materializer, fields, nullsFirst, reverse, resetter)
+	return &Sort{rctx: rctx, samsort: s}
 }
 
 func (s *Sort) Pull(done bool) (vector.Any, error) {