-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Low-hanging fruit in vector.Read (#4881)
* Read directly from segmap rather than using `ReadBytes`. * Include a count in each segment (this is a breaking change to vng). Use this to pre-size slices. * Reuse a single buffer across all internal read calls. * Avoid unnecessary copies for string/bytes vectors. * Correctly handle dict vectors, now that they're enabled. * Add a benchmark tracking vng read performance and comparing it to zng and raw varints. On wrccdc_mono_10m.vng this cuts vector.Read time from 270ms -> 140ms for id.resp_p and 470ms -> 180ms for uid.
- Loading branch information
Showing
13 changed files
with
499 additions
and
404 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.