Remove runtime/sam/expr.Cutter.Quiet (#5282)

It's been a no-op since #4627.
brimdata · Sep 16, 2024 · 4a1ebf5 · 4a1ebf5
1 parent 62930df
commit 4a1ebf5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/compiler/ast/dag/op.go b/compiler/ast/dag/op.go
@@ -35,9 +35,8 @@ type (
 		Kind string `json:"kind" unpack:""`
 	}
 	Cut struct {
-		Kind  string       `json:"kind" unpack:""`
-		Args  []Assignment `json:"args"`
-		Quiet bool         `json:"quiet"`
+		Kind string       `json:"kind" unpack:""`
+		Args []Assignment `json:"args"`
 	}
 	Drop struct {
 		Kind string `json:"kind" unpack:""`

diff --git a/compiler/kernel/op.go b/compiler/kernel/op.go
@@ -156,9 +156,6 @@ func (b *Builder) compileLeaf(o dag.Op, parent zbuf.Puller) (zbuf.Puller, error)
 		}
 		lhs, rhs := splitAssignments(assignments)
 		cutter := expr.NewCutter(b.rctx.Zctx, lhs, rhs)
-		if v.Quiet {
-			cutter.Quiet()
-		}
 		return op.NewApplier(b.rctx, parent, cutter, b.resetters), nil
 	case *dag.Drop:
 		if len(v.Args) == 0 {

diff --git a/runtime/sam/expr/cutter.go b/runtime/sam/expr/cutter.go
@@ -20,7 +20,6 @@ type Cutter struct {
 	droppers     map[string]*Dropper
 	dropperCache []*Dropper
 	dirty        bool
-	quiet        bool
 }
 
 // NewCutter returns a Cutter for fieldnames. If complement is true,
@@ -42,10 +41,6 @@ func NewCutter(zctx *zed.Context, fieldRefs []*Lval, fieldExprs []Evaluator) *Cu
 	}
 }
 
-func (c *Cutter) Quiet() {
-	c.quiet = true
-}
-
 func (c *Cutter) FoundCut() bool {
 	return c.dirty
 }