Fix panic compiling record expression with duplicate field

Closes #3365.
brimdata · Sep 29, 2023 · be9ccad · be9ccad
1 parent f662ee1
commit be9ccad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/compiler/kernel/expr.go b/compiler/kernel/expr.go
@@ -13,6 +13,7 @@ import (
 	"github.com/brimdata/zed/runtime/op/traverse"
 	"github.com/brimdata/zed/zbuf"
 	"github.com/brimdata/zed/zson"
+	"golang.org/x/exp/slices"
 	"golang.org/x/text/unicode/norm"
 )
 
@@ -397,6 +398,9 @@ func (b *Builder) compileRecordExpr(record *dag.RecordExpr) (expr.Evaluator, err
 	for _, elem := range record.Elems {
 		switch elem := elem.(type) {
 		case *dag.Field:
+			if slices.ContainsFunc(elems, func(r expr.RecordElem) bool { return r.Name == elem.Name }) {
+				return nil, fmt.Errorf("record expression: %w", &zed.DuplicateFieldError{Name: elem.Name})
+			}
 			e, err := b.compileExpr(elem.Value)
 			if err != nil {
 				return nil, err

diff --git a/compiler/ztests/record-dup-field.yaml b/compiler/ztests/record-dup-field.yaml
@@ -0,0 +1,3 @@
+zed: yield {x:1,x:2}
+
+errorRE: 'record expression: duplicate field: "x"'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		zed: yield {x:1,x:2}

		errorRE: 'record expression: duplicate field: "x"'