describe: Fix Scope channels (#5189)

Fix is an issue with compile/describe where the channels inside of a Scope were not getting properly described.
brimdata · Jul 25, 2024 · f728ad3 · f728ad3
1 parent 07d8eb7
commit f728ad3
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/compiler/describe/analyze.go b/compiler/describe/analyze.go
@@ -149,6 +149,8 @@ func describeAggs(seq dag.Seq, parents []field.List) []field.List {
 
 func describeOpAggs(op dag.Op, parents []field.List) []field.List {
 	switch op := op.(type) {
+	case *dag.Scope:
+		return describeAggs(op.Body, parents)
 	case *dag.Fork:
 		var aggs []field.List
 		for _, p := range op.Paths {

diff --git a/compiler/optimizer/optimizer.go b/compiler/optimizer/optimizer.go
@@ -367,6 +367,8 @@ func (o *Optimizer) propagateSortKeyOp(op dag.Op, parents []order.SortKey) ([]or
 	case *dag.PoolScan, *dag.Lister, *dag.SeqScan, *dag.DefaultScan:
 		out, err := o.sortKeyOfSource(op)
 		return []order.SortKey{out}, err
+	case *dag.Scope:
+		return o.propagateSortKey(op.Body, parents)
 	default:
 		out, err := o.analyzeSortKey(op, parent)
 		return []order.SortKey{out}, err

diff --git a/service/ztests/query-describe.yaml b/service/ztests/query-describe.yaml
@@ -36,7 +36,7 @@ inputs:
   - name: scope.zed
     data: |
       type port = uint16
-      from test1
+      from test1 | fork (=> pass => yield "bar")
 
 outputs:
   - name: stdout
@@ -181,6 +181,17 @@ outputs:
               "inferred": false
           },
           "channels": [
+              {
+                  "aggregation_keys": null,
+                  "sort": {
+                      "order": "desc",
+                      "keys": [
+                          [
+                              "ts"
+                          ]
+                      ]
+                  }
+              },
               {
                   "aggregation_keys": null,
                   "sort": null