add support for arbitrary pool keys #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccanne
force-pushed
the
any-key
branch
2 times, most recently
from
57b6628 to
056153f
Compare
Much of the backend presumed the pool key was of type time. This commit generalizes the scanning logic to allow pool keys of any type. The seek index has been simplified to use a simple, flat index that is no long a "micro index". Instead it is a simple, single-level list of keys that is used at open to get the scan range for a row object when the scan is smaller than the whole object. This design presumes the index will be cached when running multiple queries over a sub-range within a row object. While updating tests, we noticed the segment size and row_size fields were virtually the same so we deleted the size field. As part of this commit, the index package was updated to use zson format for key parsing instead of the deprecated tzng format, so we removed zio/tzngio/builder.go.
nwt
reviewed
May 18, 2021
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
May 19, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2729, authored by @mccanne, has been merged. add support for arbitrary pool keys The backend previously presumed the pool key was of type time. This commit generalizes the scanning logic to allow pool keys of any type. The seek index has been simplified to use a simple, flat index that is no longer a "micro index". Instead it is a simple, single-level list of keys that is used at open to get the scan range for a row object when the scan is smaller than the whole object. This design presumes the index will be cached when running multiple queries over a sub-range within a row object. While updating tests, we noticed the segment size and row_size fields were virtually the same so we deleted the size field. As part of this commit, the index package was updated to use zson format for key parsing instead of the deprecated tzng format, so we removed zio/tzngio/builder.go. Closes brimdata/super#2482
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
May 19, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2729, authored by @mccanne, has been merged. add support for arbitrary pool keys The backend previously presumed the pool key was of type time. This commit generalizes the scanning logic to allow pool keys of any type. The seek index has been simplified to use a simple, flat index that is no longer a "micro index". Instead it is a simple, single-level list of keys that is used at open to get the scan range for a row object when the scan is smaller than the whole object. This design presumes the index will be cached when running multiple queries over a sub-range within a row object. While updating tests, we noticed the segment size and row_size fields were virtually the same so we deleted the size field. As part of this commit, the index package was updated to use zson format for key parsing instead of the deprecated tzng format, so we removed zio/tzngio/builder.go. Closes brimdata/super#2482
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend previously presumed the pool key was of type time.
This commit generalizes the scanning logic to allow pool keys of any type.
The seek index has been simplified to use a simple, flat
index that is no longer a "micro index". Instead it is a simple,
single-level list of keys that is used at open to get the
scan range for a row object when the scan is smaller than the
whole object. This design presumes the index will be cached
when running multiple queries over a sub-range within a row object.
While updating tests, we noticed the segment size and row_size
fields were virtually the same so we deleted the size field.
As part of this commit, the index package was updated to use
zson format for key parsing instead of the deprecated tzng format,
so we removed zio/tzngio/builder.go.
Closes #2482