service/search: ignore request span if pool has no span #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccanne
approved these changes
May 20, 2021
mccanne
reviewed
May 20, 2021
| @@ -132,6 +132,18 @@ func (s *SearchOp) Run(ctx context.Context, adaptor proc.DataAdaptor, pool *lake | |||
| return driver.RunWithLakeAndStats(ctx, d, seq, zctx, adaptor, statsTicker.C, s.logger, parallelism) | |||
| } | |||
|
|
|||
| func poolHasSpan(ctx context.Context, pool *lake.Pool) bool { | |||
There was a problem hiding this comment.
I think this can just check len(pool.Layout.Keys) == 0
There was a problem hiding this comment.
That'll break the app in a different way since it currently creates pools with no key.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
May 20, 2021
…o span" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2745, authored by @nwt, has been merged. service/search: ignore request span if pool has no span Closes brimdata/super#2740.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
May 20, 2021
…o span" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2745, authored by @nwt, has been merged. service/search: ignore request span if pool has no span Closes brimdata/super#2740.
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
May 20, 2021
…o span" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2745, authored by @nwt, has been merged. service/search: ignore request span if pool has no span Closes brimdata/super#2740.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
May 20, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2747, authored by @nwt, has been merged. service: add test for non-time ts field I meant to include this in brimdata/super#2745.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
May 20, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2747, authored by @nwt, has been merged. service: add test for non-time ts field I meant to include this in brimdata/super#2745.
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
May 20, 2021
This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2747, authored by @nwt, has been merged. service: add test for non-time ts field I meant to include this in brimdata/super#2745.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2740.