-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in lake scan when merging by non-ts pool key #2752
Conversation
if len(pullers) == 1 { | ||
merger = pullers[0] | ||
} else if len(keys) > 0 && len(keys[0]) == 1 && keys[0][0] == "ts" { | ||
merger = zbuf.MergeByTs(ctx, pullers, pool.Layout.Order) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're eventually going to have to address the fact that zbuf.MergeByTs
doesn't do the right thing for records with a non-time
ts
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can easily be part of the JIT-CG. The scan scheduler can look at the metadata across a partition to see inspect the type signature(s) for the pool key.
FWIW, I just tested out the branch using the original repro steps and it looks good to me too.
|
…key" by mccanne This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2752, authored by @mccanne, has been merged. fix bug in lake scan when merging by non-ts pool key closes brimdata/super#2749
…key" by mccanne This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2752, authored by @mccanne, has been merged. fix bug in lake scan when merging by non-ts pool key closes brimdata/super#2749
…key" by mccanne This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2752, authored by @mccanne, has been merged. fix bug in lake scan when merging by non-ts pool key closes brimdata/super#2749
closes #2749