Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode top-level array incrementally in zio/jsonio #3123

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

nwt
Copy link
Member

@nwt nwt commented Sep 29, 2021

Reading a large, top-level JSON array with zio/jsonio.Reader is
impractical because it decodes the full input on the first call to its
Read method. Decode top-level arrays incrementally instead.

Closes #2677.

Reading a large, top-level JSON array with zio/jsonio.Reader is
impractical because it decodes the full input on the first call to its
Read method.  Decode top-level arrays incrementally instead.
@nwt nwt requested review from philrz and a team September 29, 2021 14:50
Copy link
Collaborator

@mattnibs mattnibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@nwt nwt merged commit 020a839 into main Sep 29, 2021
@nwt nwt deleted the zio-zjsonio-incremental branch September 29, 2021 15:29
brim-bot pushed a commit to brimdata/brimcap that referenced this pull request Sep 29, 2021
…o" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#3123, authored by @nwt,
has been merged.

decode top-level array incrementally in zio/jsonio

Reading a large, top-level JSON array with zio/jsonio.Reader is
impractical because it decodes the full input on the first call to its
Read method.  Decode top-level arrays incrementally instead.

Closes brimdata/super#2677.
brim-bot pushed a commit to brimdata/brimcap that referenced this pull request Sep 29, 2021
…o" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#3123, authored by @nwt,
has been merged.

decode top-level array incrementally in zio/jsonio

Reading a large, top-level JSON array with zio/jsonio.Reader is
impractical because it decodes the full input on the first call to its
Read method.  Decode top-level arrays incrementally instead.

Closes brimdata/super#2677.
brim-bot pushed a commit to brimdata/zui that referenced this pull request Sep 29, 2021
…o" by nwt

This is an auto-generated commit with a Zed dependency update. The Zed PR
brimdata/super#3123, authored by @nwt,
has been merged.

decode top-level array incrementally in zio/jsonio

Reading a large, top-level JSON array with zio/jsonio.Reader is
impractical because it decodes the full input on the first call to its
Read method.  Decode top-level arrays incrementally instead.

Closes brimdata/super#2677.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading larger JSON arrays
2 participants