Remove unnecessary sorts before joins in ztests #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove sort operators before joins in ztests that are unnecessary now that join automatically sorts its inputs. compiler/ztests/join-desc.yaml is left unmodified since it is explicitly testing inputs with descending order. zfmt/ztests/decls.yaml is modified for consistency, even though removing the sorts affects the output (which is formatted Zed, not query results).
philrz
approved these changes
Sep 27, 2023
runtime/op/join/ztests/kinds.yaml
Outdated
Comment on lines
3
to
9
| zq -z 'anti join (file B.zson) on a=b | sort a' A.zson | ||
| zq -z 'anti join (file B.zson) on a=b' A.zson | ||
| echo === LEFT === | ||
| zq -z 'left join (file B.zson) on a=b hit:=sb | sort a' A.zson | ||
| zq -z 'left join (file B.zson) on a=b hit:=sb' A.zson | ||
| echo === INNER === | ||
| zq -z 'inner join (file B.zson) on a=b hit:=sb | sort a' A.zson | ||
| zq -z 'inner join (file B.zson) on a=b hit:=sb' A.zson | ||
| echo === RIGHT === | ||
| zq -z 'right join (file C.zson) on b=c hit:=sb | sort c' B.zson |
There was a problem hiding this comment.
While reviewing, I happened to notice that the original actually looks broken here, since the | sort are being tacked on after the join. It looks like it only worked consistently because the inputs happened to be pre-sorted by the respective keys.
There was a problem hiding this comment.
Well spotted! I'll back out the change to this file since these sorts aren't before the join.
mattnibs
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove sort operators before joins in ztests that are unnecessary now that join automatically sorts its inputs.
compiler/ztests/join-desc.yaml is left unmodified since it is explicitly testing inputs with descending order.
zfmt/ztests/decls.yaml is modified for consistency, even though removing the sorts affects the output (which is formatted Zed, not query results).