Parallelize more source paths #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking for source paths to parallelize, the optimizer.walkEntries
examines only the first operator in a sequence. This prevents the
optimizer from parallelizing a pool scan in the right input of a join
expressed in subquery syntax, like
from left | join (from right | ...) on left_key=right_key
Change walkEntries to examine all operators in a sequence so almost all
source paths are parallelized. (The exceptions are paths inside
dag.Over and paths containing no operator after the source.)
mattnibs
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for source paths to parallelize, the optimizer.walkEntries examines only the first operator in a sequence. This prevents the optimizer from parallelizing a pool scan in the right input of a join expressed in subquery syntax, like
Change walkEntries to examine all operators in a sequence so almost all source paths are parallelized. (The exceptions are paths inside dag.Over and paths containing no operator after the source.)