Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused lake/data.Object methods #4792

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove unused lake/data.Object methods #4792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lake/data/object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,6 @@ func plural(ordinal int) string {
return "s"
}

func (o Object) StringRange() string {
return fmt.Sprintf("%s %s %s", o.ID, o.Min, o.Max)
}

func (o *Object) Equal(to *Object) bool {
return o.ID == to.ID
}
Expand Down Expand Up @@ -145,11 +141,6 @@ func VectorURI(path *storage.URI, id ksuid.KSUID) *storage.URI {
return path.JoinPath(fmt.Sprintf("%s.vng", id))
}

func (o Object) Range() string {
//XXX need to handle any key... will the String method work?
return fmt.Sprintf("[%d-%d]", o.Min, o.Max)
}

// Remove deletes the row object and its seek index.
// Any 'not found' errors are ignored.
func (o Object) Remove(ctx context.Context, engine storage.Engine, path *storage.URI) error {
Expand Down