Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join with nulls #4801

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix join with nulls #4801

merged 1 commit into from
Oct 11, 2023

Conversation

mattnibs
Copy link
Collaborator

For auto join sorts make sure nulls are max or last.

Closes #4800

@mattnibs mattnibs requested a review from a team October 10, 2023 23:42
@mattnibs
Copy link
Collaborator Author

Weird the nullsMax for the sort op is actually nullsFirst which is the inverse of nullsMax. Confusing and should probably be fixed but first get join working.

@mattnibs mattnibs force-pushed the join-nulls-first branch 3 times, most recently from 5075982 to c6a3122 Compare October 11, 2023 00:02
@mattnibs
Fix join with nulls
11c410e 
For auto join sorts make sure nulls are max or last.

Closes #4800
@mattnibs mattnibs merged commit da25095 into main Oct 11, 2023
3 checks passed
@mattnibs mattnibs deleted the join-nulls-first branch October 11, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Join not producing output
2 participants
@mattnibs @nwt