Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic fields in rename #4802

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Dynamic fields in rename #4802

merged 1 commit into from
Oct 27, 2023

Conversation

mattnibs
Copy link
Collaborator

Add the ability to rename fields dynamic for the rename op.

@mattnibs mattnibs requested a review from a team October 11, 2023 17:25
@mattnibs mattnibs force-pushed the dynamic-paths branch 3 times, most recently from 8ca2498 to 6f6dfec Compare October 11, 2023 19:47
@mattnibs mattnibs force-pushed the dynamic-paths branch 6 times, most recently from ab23f99 to 2208eab Compare October 12, 2023 18:45
@mattnibs mattnibs force-pushed the dynamic-paths branch 12 times, most recently from ef7ea3a to fc53ee3 Compare October 18, 2023 18:53
@mattnibs mattnibs force-pushed the dynamic-paths branch 3 times, most recently from ec310b9 to 35d5733 Compare October 25, 2023 16:25
Base automatically changed from dynamic-paths to main October 25, 2023 17:34
@mattnibs mattnibs force-pushed the dynamic-rename branch 5 times, most recently from 127a241 to f0c2686 Compare October 25, 2023 19:41
compiler/semantic/op.go Outdated Show resolved Hide resolved
compiler/kernel/op.go Outdated Show resolved Hide resolved
runtime/expr/renamer.go Outdated Show resolved Hide resolved
pkg/field/field.go Show resolved Hide resolved
pkg/field/field.go Show resolved Hide resolved
compiler/semantic/op.go Outdated Show resolved Hide resolved
@mattnibs mattnibs force-pushed the dynamic-rename branch 3 times, most recently from a857b9a to 4065d37 Compare October 27, 2023 20:03
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: when CI is green.

Add the ability to rename fields dynamic for the rename op.
@mattnibs mattnibs merged commit 9abaa77 into main Oct 27, 2023
4 checks passed
@mattnibs mattnibs deleted the dynamic-rename branch October 27, 2023 21:28
@philrz philrz linked an issue Oct 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zed shorthand to create a record field name from string
2 participants