Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ztest for math between all numeric types #5091

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add a ztest for math between all numeric types #5091

merged 1 commit into from
Jun 17, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Mar 26, 2024

As discussed in #5086, this PR proposes a ztest that performs simple math between all numeric types. #5086 (comment) shows an example of how drastically the output would differ if a bug like #4719 crept back in.

@philrz philrz requested a review from a team March 26, 2024 21:40
@philrz philrz self-assigned this Mar 26, 2024
@philrz philrz mentioned this pull request Apr 23, 2024
Merged
nwt
nwt approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates some of TestArithmetic in runtime/sam/epxr/expr_test.go and I think it'd make sense to consolidate the two, but we can do that later.

@philrz philrz merged commit 2185f30 into main Jun 17, 2024
3 checks passed
@philrz philrz deleted the math-coerce-ztest branch June 17, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees

@philrz philrz

Labels
skip-autoperf skip-notify-downstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philrz @nwt