ast: Add TypeDecl Node #5102
Merged
ast: Add TypeDecl Node #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
approved these changes
Apr 6, 2024
| if err := a.scope.DefineConst(a.zctx, d.Name, e); err != nil { | ||
| return dag.Def{}, err | ||
| } | ||
| return dag.Def{Name: d.Name, Expr: e}, nil |
There was a problem hiding this comment.
Nit: These are on multiple lines everywhere else in here.
Suggested change
| return dag.Def{Name: d.Name, Expr: e}, nil | |
| return dag.Def{ | |
| Name: d.Name, | |
| Expr: e | |
| }, nil |
There was a problem hiding this comment.
For me I follow my made up rule that if a struct declaration fits below 80 characters, I do it single line. I think that seems reasonable, no?
There was a problem hiding this comment.
Totally reasonable. I just prefer to see changes follow the prevailing style. Just a nit though so do as you like!
mattnibs
force-pushed
the
type-decl
branch
2 times, most recently
from
3fa90aa to
8e97d69
Compare
This commit adds a separate AST decl type for type declarations as opposed to using const deleclartions for this case. This is part of a series of changes preparing the AST code base to support position information for AST nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a separate AST decl type for type declarations as opposed to using const deleclartions for this case. This is part of a series of changes preparing the AST code base to support position information for AST nodes.