Revert "Introduce zed.Arena (#5118)" and "sort: Fix spill garbage collection bug (#5239)" #5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection bug (#5239)" This reverts commits ce9626e and 1ffe14f. A zed.Value allocated by a zed.Arena holds an untyped pointer to the arena in zed.Value.a, hiding the arena from the garbage collector and requiring maintenance elsewhere of a typed pointer that lives as long as the zed.Value. Failure to do so reliably has so far led to three distinct panics not caught by automated tests, and more are likely to appear. At the same time, arenas haven't produced the anticipated performance benefit, in part because they introduce new bottlenecks without obvious fixes. In this light and given current priorities, time spent fixing arena bugs isn't well spent, so this change removes zed.Arena.
mattnibs
approved these changes
Sep 16, 2024
This was
linked to
issues
Sep 16, 2024
This was referenced Sep 16, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commits ce9626e and 1ffe14f.
A zed.Value allocated by a zed.Arena holds an untyped pointer to the arena in zed.Value.a, hiding the arena from the garbage collector and requiring maintenance elsewhere of a typed pointer that lives as long as the zed.Value. Failure to do so reliably has so far led to three distinct panics not caught by automated tests, and more are likely to appear.
At the same time, arenas haven't produced the anticipated performance benefit, in part because they introduce new bottlenecks without obvious fixes.
In this light and given current priorities, time spent fixing arena bugs isn't well spent, so this change removes zed.Arena.
Closes #5150, #5154, #5259