change variant to dynamic #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes our terminology for a top-level dynamic type to "Dynamic" from "Variant". The term "variant" has been corrupted by the industry to mean efficiently-encoded semi-structured data when the traditional meaning from programming languages is a tagged union. To avoid this confusion, we're following clickhouse's terminology and using the term dynamic instead. This change is internal to the code only and does not affect any user-facing documentation as the super-structured data model is strongly typed throughout and does not expose the implied top-level dynamic type as a user-visible type.
mattnibs
approved these changes
Sep 25, 2024
mccanne
added a commit
that referenced
this pull request
Oct 20, 2024
We made a breaking change to the vng/supc format in #5302 but we neglected to change the file format version number. This commit changes the version number to provide a version mismatch error instead of strange sanity-check failure.
mccanne
added a commit
that referenced
this pull request
Oct 20, 2024
We made a breaking change to the vng/supc format in #5302 but we neglected to change the file format version number. This commit changes the version number to provide a version mismatch error instead of strange sanity-check failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes our terminology for a top-level dynamic type to "Dynamic" from "Variant". The term "variant" has been corrupted by the industry to mean efficiently-encoded semi-structured data when the traditional meaning from programming languages is a tagged union. To avoid this confusion, we're following clickhouse's terminology and using the term dynamic instead. This change is internal to the code only and does not affect any user-facing documentation as the super-structured data model is strongly typed throughout and does not expose the implied top-level dynamic type as a user-visible type.