vector.View: rebuild nulls #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
vector-view-nulls
branch
from
004270e to
cc2ee7a
Compare
The commit changes the behavior when wrapping Const, Errors and Unions. Consts and Errors are now rebuilt rather than getting wrapped in a View. For all these values if there is a non-nil nulls value the Bool vector is rebuilt.
mattnibs
force-pushed
the
vector-view-nulls
branch
from
cc2ee7a to
cd2fc31
Compare
nwt
reviewed
Oct 1, 2024
nwt
approved these changes
Oct 1, 2024
Co-authored-by: Noah Treuhaft <[email protected]>
mattnibs
force-pushed
the
vector-view-nulls
branch
from
47929ee to
8c39fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit changes the behavior when wrapping Const, Errors and Unions. Consts and Errors are now rebuilt rather than getting wrapped in a View. For all these values if there is a non-nil nulls value the Bool vector is rebuilt.