vam: Add support for conditionals (case expr) #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
vam-conditional
branch
2 times, most recently
from
90dbe4b to
629b838
Compare
mattnibs
changed the title
nwt
reviewed
Nov 21, 2024
| } else { | ||
| errs.AddRange(0, uint64(vec.Len())) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is the absence of a default case here intentional?
There was a problem hiding this comment.
On second thought I don't think it should. Have no default just sets the return value to false for non-bool vectors just like vector.BoolValue does
Comment on lines
+34
to
+42
| // errors are ignored for filters | ||
| b, _ := expr.BoolMask(mask) | ||
| if b.IsEmpty() { | ||
| return nil, false | ||
| } | ||
| if len(index) == int(n) { | ||
| if b.GetCardinality() == uint64(mask.Len()) { | ||
| return vec, true | ||
| } | ||
| return vector.NewView(vec, index), true | ||
| return vector.NewView(vec, b.ToArray()), true |
There was a problem hiding this comment.
What does this change have to do with implementing conditionals?
There was a problem hiding this comment.
Just figured not to have two different boolMask functions plus the new one is more optimized
mattnibs
force-pushed
the
vam-conditional
branch
from
629b838 to
bac0723
Compare
mattnibs
force-pushed
the
vam-conditional
branch
from
bac0723 to
d272f8b
Compare
nwt
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.