Use CSUP files in vector runtime #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
csup-multiple-objects
branch
from
85b4740 to
b1f99bd
Compare
mattnibs
force-pushed
the
parallel-csup
branch
from
ad8034f to
162507b
Compare
mattnibs
force-pushed
the
parallel-csup
branch
from
162507b to
efb9335
Compare
mattnibs
force-pushed
the
csup-multiple-objects
branch
from
b1f99bd to
178acba
Compare
mattnibs
force-pushed
the
parallel-csup
branch
from
efb9335 to
6cef3c5
Compare
mattnibs
force-pushed
the
csup-multiple-objects
branch
from
178acba to
46a0f43
Compare
mattnibs
force-pushed
the
parallel-csup
branch
5 times, most recently
from
31b0741 to
0c190e5
Compare
The commit adds the ability to use CSUP files in vector runtime. It also implements the NewConcurrentPuller protocol to enable parallel read of a CSUP file in vector runtime.
mattnibs
force-pushed
the
parallel-csup
branch
from
0c190e5 to
f9b9618
Compare
nwt
approved these changes
Dec 3, 2024
nwt
reviewed
Dec 3, 2024
| func (v *VectorReader) close() error { | ||
| if v.activeReaders.Add(-1) <= 0 { | ||
| if closer, ok := v.readerAt.(io.Closer); ok { | ||
| return closer.Close() // coffee is for closers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds the ability to use CSUP files in vector runtime. It also implements the NewConcurrentPuller protocol to enable parallel read of a CSUP file in vector runtime.