Hyperlink fixes #5509
Closed
Hyperlink fixes #5509
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like moving to a different link checker may be a better fix here. Closing this one without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Make some link checker failures go away.
Details
I made a mistake in one of my aspirational "it'll start working once it merges" hyperlinks in #5506, so I tried fixing that here. That revealed that the markdown link checker we've been using also seems to have some kind of bug with hyperlinks containing percent encoding. I just added a comment to an existing issue with a simple repro example, but for now I've added an exclusion in our link checker config. This also led me to notice that the guy who maintained that markdown link checker has a new tool linkspector that seems to be more actively maintained, so I'll separately look into whether we can move over to that one and maybe not have to do exclusions.
While I'm at it, I'm also adjusting the hyperlink for an Apache Hive reference. Their design docs happen to be on a public Confluence site and it must not be built for scale because it seems like 50% of the time our link checker experiences some kind of timeout trying to crawl it. Rather than drop the hyperlink entirely or add an exclusion to the link checker I'm opting to just point to something one link further back in their "real" web site.