Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement vector switch operator #5538

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Implement vector switch operator #5538

merged 3 commits into from
Dec 18, 2024

Conversation

nwt
Copy link
Member

@nwt nwt commented Dec 18, 2024

No description provided.

@nwt nwt requested a review from a team December 18, 2024 01:15
mattnibs
mattnibs reviewed Dec 18, 2024
View reviewed changes
runtime/vam/op/exprswitch.go
route = s.defaultRoute
}
if route != nil {
s.caseIndexes[route] = append(s.caseIndexes[route], i)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to truncate caseIndexes each time you get a new vector.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in afa044f and e8bc7ef.

@nwt nwt merged commit ef76d4d into main Dec 18, 2024
3 checks passed
@nwt nwt deleted the vector-switch branch December 18, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnibs mattnibs mattnibs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwt @mattnibs