Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run super command perf tests in vector runtime that couldn't before #5552

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Dec 28, 2024

What's Changing

Query performance results are added to the super command doc for tests that couldn't be run previously, thanks to the merge of recent PRs that enabled new functionality in vector runtime.

Why

This allows us to get rid of some cells in the results summary where we previously had disclaimers saying we couldn't run these yet.

Details

When making these updates I hoped to show vector CSUP performance with these queries as well, but I bumped into new issue #5550. Therefore I've left the relevant parts of the scripts commented out for now, but will revisit once #5550 is addressed.

@philrz philrz requested a review from a team December 28, 2024 00:38
@philrz philrz self-assigned this Dec 28, 2024
Comment on lines +736 to +738
This code path in `super` is not multi-threaded so not particularly performant,
but on our test machine it runs a bit faster than both the `duckdb` method of
creating a schema-fused table or loading the data to the `clickhouse` beta JSON type.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I used the same DuckDB release version and AWS instance type as the last time I ran these tests, for some reason DuckDB did happen to run this "table creation" step substantially faster than last time (328 seconds now vs. 513 seconds last time). I can't explain it offhand and I'm not inspired to take a detour and study it deeply, but in the interest of science I've corrected the summary here to reflect that. I'll keep an eye on it in future runs and maybe the operation just turns out to have high variance.

ClickHouse's beta JSON type_
Since DuckDB with its native format could successfully run all queries with
decent performance, we used it as the baseline for all of the speed-up factors.
To summarize,
`super` with Super Binary is substantially faster than multiple relational systems for
the search use cases and performs on par with the others for traditional OLAP queries,
the search use cases, and with Parquet performs on par with the others for traditional OLAP queries,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially now that we have across-the-boards Parquet results, I figured I might as well clarify that those are the ones where super perf comes closest with OLAP queries. Looking forward to seeing CSUP showing the best performance. 🤞

@philrz philrz changed the title Super cmd perf dec2024 Run super command perf tests in vector runtime that couldn't before Dec 28, 2024
@philrz philrz merged commit a070a07 into main Jan 7, 2025
5 checks passed
@philrz philrz deleted the super-cmd-perf-dec2024 branch January 7, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants