Change NDJSON references to just JSON #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing
Explicit references to "NDJSON" have been changed to just "JSON".
This is a companion to brimdata/super#5360. Ideally this one should merge first.
Why
Some NDJSON->JSON changes were made in brimdata/super#5346. After hearing consensus that this is something we wanted to continue doing more widely, I went to change some more references in the super repo, but I stalled when I got to the
perf-compare.shscript that had been referencing thezeek-ndjson/directory in this repo by name.Details
I'm aware this will need another round of changes when we update the names of the super formats.