notify on failures #1617
notify on failures #1617
Conversation
Signed-off-by: Mason Fish <[email protected]>
| @@ -177,10 +177,10 @@ export default class BrimcapPlugin { | |||
| // ) | |||
|
|
|||
| const tsString = ts.toString() | |||
| const dur = log.get("duration") as zed.Duration | |||
| const dur = log.try("duration") as zed.Duration | |||
There was a problem hiding this comment.
Try can return null. In the returned object, check for null before calling isSet().
There was a problem hiding this comment.
I ended up doing just that down a bit further at https://github.com/brimdata/brim/pull/1617/files#diff-00e37cfd83eb8f0d73899b431f6d59bbad7c73d7bc1e8ea6acbf1eba935ee120R189
There was a problem hiding this comment.
Oh wait I misunderstood, disregard last message. Just pushed a fix.
Signed-off-by: Mason Fish <[email protected]>
|
Nit: @mccanne has voiced a preference for writing "pcap" rather than "PCAP" because it's not strictly an acronym. And he's the guy who came up with libpcap, so I guess that carries some weight. 😉 |
|
For the "
That is, in the current error message as written, just saying "log" doesn't give the user a whole lot of info to go on to understand if they're seeing a bug or they tried something that shouldn't have worked. I suppose if this came up a lot (which we don't expect it to) a Support article to link to would be justified (a more detailed explanation of how we index the pcap & then find stuff in it) but this'll do for now. I also figured we might as well say "connection record" (as opposed to |
Signed-off-by: Mason Fish <[email protected]>
fixes #1616
Provides more information to users for two error cases:
Attempting to launch wireshark on an any
connrecord that has no 5-tuple informationAttempting to launch wireshark when no pcaps are found in the search
Signed-off-by: Mason Fish [email protected]