Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "release" target to avoid clash with "nx release" #2891

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Nov 10, 2023

When trying to build the GA Zui v1.4.0 release candidates it became apparent that the move from nx 15.8.7 to 16.10.0 as part of #2834 caused an unexpected problem: Somewhere between those versions they introduced an nx release command that happened to clash with our use of release as a target in Zui's package.json. Once that was understood, the workaround of changing the target name as shown in this PR got me up & running again quickly.

Since we already had release-insiders I opted to call the new target release-zui for symmetry. Then I did similar treatment turning the adjacent package target into package-zui for consistency, plus it insulates us against the possibility that the verb package gets claimed one day by nx as well. 😛

@philrz philrz requested a review from jameskerr November 10, 2023 20:51
@philrz philrz self-assigned this Nov 10, 2023
@philrz philrz merged commit cabf2d9 into main Nov 10, 2023
6 checks passed
@philrz philrz deleted the release/v1.4.0 branch November 10, 2023 21:30
@philrz philrz restored the release/v1.4.0 branch November 10, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants