Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "release" target to avoid clash with "nx release" #2891

Merged
merged 1 commit into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Build Zui
uses: ./.github/actions/build-zui
with:
cmd: yarn nx package zui
cmd: yarn nx package-zui zui
gh_token: ${{ secrets.GITHUB_TOKEN }}
# Windows
csc_key_password: ${{ secrets.WINDOWS_SIGNING_PASSPHRASE }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
set -x
case ${{ runner.os }} in
Linux )
yarn nx package zui --linux=deb --publish never
yarn nx package-zui zui --linux=deb --publish never
sudo apt install -y --no-install-recommends ./dist/apps/zui/*.deb
;;
esac
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Build Zui
uses: ./.github/actions/build-zui
with:
cmd: yarn nx release zui
cmd: yarn nx release-zui zui
gh_token: ${{ secrets.GITHUB_TOKEN }}
# Windows
csc_key_password: ${{ secrets.WINDOWS_SIGNING_PASSPHRASE }}
Expand Down
4 changes: 2 additions & 2 deletions apps/zui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"tsc": "tsc",
"postinstall": "node scripts/post-install",
"prepare": "husky install",
"package": "electron-builder --publish never",
"release": "electron-builder",
"package-zui": "electron-builder --publish never",
"release-zui": "electron-builder",
"package-insiders": "electron-builder --config electron-builder-insiders.json --publish never",
"release-insiders": "electron-builder --config electron-builder-insiders.json --publish always"
},
Expand Down
Loading