Change "advance-zed" workflow to "advance-super" #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
commented
Mar 5, 2025
| @@ -34,22 +34,19 @@ jobs: | |||
| # that caused it to wait, reducing push failures down below. | |||
| ref: ${{ github.ref }} | |||
| # We need a token with permission to push. | |||
| token: ${{ secrets.ZQ_UPDATE_PAT }} | |||
| token: ${{ secrets.PAT_TOKEN }} | |||
There was a problem hiding this comment.
That Actions secret called ZQ_UPDATE_PAT hasn't been updated in 4 years and this is the only Workflow that's been using it. Since it has "ZQ" in its name I'm inclined to get rid of it, and since we have another secret called PAT_TOKEN that's used in other Workflows and that one is only 2 years old, I'm game to give that one a shot on the assumption it probably has the appropriate permissions. Once we see this Workflow run successfully with PAT_TOKEN I'll delete the ZQ_UPDATE_PAT secret from the GitHub config.
philrz
commented
Mar 5, 2025
Comment on lines
-47
to
-49
| # Mock for pcap slice opening to avoid hanging Actions Runner. | ||
| # See https://github.com/brimdata/zui/pull/2987 | ||
| echo "application/vnd.tcpdump.pcap; /usr/bin/true" >> /home/runner/.mailcap |
There was a problem hiding this comment.
Since we're not keeping the pcap-centric functionality alive in the app anymore it seems it should be safe to drop this hack.
This was referenced Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in October, 2024 via brimdata/super#5347 I disabled the auto-update of the Zed dependency in the Zui repo because changes in super were starting to happen that would break the app. We were focused on other things at the time so we didn't prioritize getting them back in sync and keeping them that way. Now that @jameskerr has recently done the work to start turning Zui into SuperDB Desktop and we've got the app working again with a recent super commit, it seems like it's time to get this auto-update workflow running again so the app will always have the benefit of the latest super changes and we'll know immediately when something breaks it.
While we're at it, here I've done some de-Zed-ing of the workflow in question. Once this is merged and it's prepared to receive the updates from the super side, I'll put up a PR in the super repo to make sure the merge commit notifications are sent with the correct event name and such that it'll match what's done here.