Replace wordexp with custom implementation #2167
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview for conkyweb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Caellian
force-pushed
the
dev/real-path-improvements
branch
from
c838221 to
f95095d
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/real-path-improvements
branch
from
f95095d to
8569f77
Compare
github-actions
bot
removed
documentation
Caellian
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces wordexp with custom implementation for all platforms. Precursor of this implementation was used on platforms without
wordexp, so this PR consolidates the two into one.Linux version will loose ability to use some less commonly used expansions such as field splitting. The important things will be reimplemented, the removed stuff is basically things that don't make sense i.e. only work well in terminal or shell scripts (e.g. field splitting depends on IFS env variable which isn't controlled by conky anyway; some other things that).
BSDs, Solaris, etc. will get much better handling of paths - they'll be able to use command expansion and math expansion.
TODO
algebra.ccwith code fromtinyexpr