Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Compose configuration for OAuth proxy #154

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

nawatts
Copy link
Contributor

@nawatts nawatts commented Aug 19, 2019

No description provided.

@nawatts nawatts requested a review from knguyen142 August 19, 2019 20:35
To generate a random secret key, use:

```
python manage.py shell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you thought of bringing this logic into manage.py e.g. python manage.py random_secret

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not, but this is likely so rare a task that I'm not sure it warrants a manage.py command, since the alternative is two lines.

- Configure app. Fill in values below.

```
cat <<EOF > .env

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some instruction somewhere on what these values mean? It might be easier to seed this with information and do

OAUTH2_PROXY_COOKIE_SECRET=$(<Random generator command>)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked to the OAuth proxy configuration documentation, but yes these could be better described. The environment variables for application settings should probably also be documented somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #156 to document configuration.

@nawatts nawatts merged commit ac1fef1 into master Aug 20, 2019
@nawatts nawatts deleted the oauth-proxy-docker-compose branch August 20, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants