-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect aggregation #102
Connect aggregation #102
Conversation
Visit the preview URL for this PR (updated for commit 11eb152): https://ccv-pubs--pr102-connect-aggregation-2sfq2b8n.web.app (expires Tue, 04 Feb 2025 20:49:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f75c16b3bdd7d81b7a0b7f8d3eed826b541e7a2a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I added in a comment to remove a comment. Also thanks for updating the firebase rules as well, I went to check briefly and you had it all covered !!! Great job George !!!
src/components/BarChart.js
Outdated
const fetchData = async () => { | ||
try { | ||
const fetchedData = await getAggregation({ documentName: 'publicationsByYear' }); | ||
// console.log(fetchedData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment! can delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting a quick change actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops! forgot to approve! Sorry george! approving now
Connected data from the aggregations stored on Firestore to the barplot component.