Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect aggregation #102

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Connect aggregation #102

merged 6 commits into from
Jan 28, 2025

Conversation

gtdang
Copy link
Member

@gtdang gtdang commented Jan 17, 2025

Connected data from the aggregations stored on Firestore to the barplot component.

@gtdang gtdang requested a review from eldu January 17, 2025 22:27
Copy link

github-actions bot commented Jan 17, 2025

Visit the preview URL for this PR (updated for commit 11eb152):

https://ccv-pubs--pr102-connect-aggregation-2sfq2b8n.web.app

(expires Tue, 04 Feb 2025 20:49:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f75c16b3bdd7d81b7a0b7f8d3eed826b541e7a2a

Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I added in a comment to remove a comment. Also thanks for updating the firebase rules as well, I went to check briefly and you had it all covered !!! Great job George !!!

const fetchData = async () => {
try {
const fetchedData = await getAggregation({ documentName: 'publicationsByYear' });
// console.log(fetchedData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment! can delete

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted!

Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting a quick change actually

src/components/BarChart.js Show resolved Hide resolved
@gtdang gtdang requested a review from eldu January 28, 2025 20:49
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops! forgot to approve! Sorry george! approving now

@gtdang gtdang merged commit c7637cb into counts-barplot Jan 28, 2025
2 checks passed
@gtdang gtdang deleted the connect-aggregation branch January 28, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants