Feat buttons #15
Merged
Feat buttons #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Visit the preview URL for this PR (updated for commit f6620dd): https://ccv-website-next--pr15-feat-buttons-urv68kcj.web.app (expires Fri, 30 Aug 2024 16:04:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 809aa2d3a6cfe026c3c7417c932015a8f1d9ec89 |
anna-murphy
approved these changes
Aug 21, 2024
components/Button.tsx
Outdated
| ); | ||
| } | ||
|
|
||
| export function ButtonSecondary({ icon, children, ...delegated }: ButtonProps) { |
There was a problem hiding this comment.
This might just be a me thing, but I feel like I'd prefer an API thats a single Button component with a variant prop that's optional and is either "secondary" or "tertiary". Do you prefer three different components?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to add three button functions within the Button.tsx component: