Clean files in local_modules #131
Conversation
|
all good here @cpaniaguam ? |
| a = "%2.1e" % low | ||
| b = "%2.1e" % high |
There was a problem hiding this comment.
Old style formatting.
| a = "%2.1e" % low | |
| b = "%2.1e" % high | |
| a = f"{low:.1e}" | |
| b = f"{high:.1e}" |
There was a problem hiding this comment.
file re-formatted
There was a problem hiding this comment.
This change didn't get applied?
|
|
||
| return a[0:3] +'-'+ b +' Hz' | ||
| return a[0:3] + "-" + b + " Hz" |
There was a problem hiding this comment.
| return a[0:3] + "-" + b + " Hz" | |
| return f"{a[0:3]}-{b} Hz" |
There was a problem hiding this comment.
file re-formatted
Co-authored-by: Carlos Paniagua <[email protected]>
Co-authored-by: Carlos Paniagua <[email protected]>
Co-authored-by: Carlos Paniagua <[email protected]>
…esat2-tracks into clean-files-modules
…esat2waves into clean-files-modules
|
@cpaniaguam I finished your last review. Check it again and let me know if I there anything I missed |
Co-authored-by: Carlos Paniagua <[email protected]>
Co-authored-by: Carlos Paniagua <[email protected]>
…esat2waves into clean-files-modules
Co-authored-by: Carlos Paniagua <[email protected]>
|
@cpaniaguam Done! Check again. |
There was a problem hiding this comment.
Looks good!
I am not really sure why most of the conversations disappeared. They didn't appear in context so I had to have two windows opened, one at the conversations page and another with the file being reviewed. Also, in the future please consider using the add suggestion to batch feature to co-author commits.
|
I did use the |
|
@hollandjg everything good on your side? |
local_modulesfolder