Update SleepRegularityIndexUtil.java #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems Joda DateTime has an issue with gaps for non existent dates caused by day light saving etc.. See https://stackoverflow.com/questions/5451152/how-to-handle-jodatime-illegal-instant-due-to-time-zone-offset-transition So I have migrated DateTime to use LocalDate instead and set the tiemzone to UTC otherwise we see crashes fro various timezones. Hope this does not break something in the calculation? org.joda.time.IllegalInstantException: Cannot parse "2022-10-16": Illegal instant due to time zone offset transition (America/Sao_Paulo) org.joda.time.format.DateTimeParserBucket.computeMillis(SourceFile:390) org.joda.time.format.DateTimeFormatter.parseDateTime(SourceFile:856) org.joda.time.DateTime.parse(SourceFile:144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Joda DateTime has an issue with gaps for non existent dates caused by day light saving etc..
See
https://stackoverflow.com/questions/5451152/how-to-handle-jodatime-illegal-instant-due-to-time-zone-offset-transition
So I have migrated DateTime to use LocalDate instead and set the tiemzone to UTC otherwise we see crashes fro various timezones. Hope this does not break something in the calculation?
org.joda.time.IllegalInstantException: Cannot parse "2022-10-16": Illegal instant due to time zone offset transition (America/Sao_Paulo)
org.joda.time.format.DateTimeParserBucket.computeMillis(SourceFile:390)
org.joda.time.format.DateTimeFormatter.parseDateTime(SourceFile:856)
org.joda.time.DateTime.parse(SourceFile:144)