improvement of residual-chart hover info #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended for embedding use cases, the type is:
type InitialState = {
editorContents: string,
interactionsSinceLastRun: string
}
On load the editor will automatically run definitions with the given
text and then run all the given interactions.
Currently only enabled in embedding contexts.
Need state for two more cases:
- Editing definitions but haven't run at all yet
- Editing definitions after a run
Co-authored-by: Irv Katz <[email protected]>
One thing that's challenging is the use of on('change') on CodeMirror,
which triggers for calls to setValue().
In the events API, we change these to all use replaceRange with an
explicit `origin`. However, there are setValue() calls elsewhere in the
codebase. We could ignore these by checking the origin of "setValue",
but this could be a mistake if we do want to propagate around updates
like those. Need to think about this.
For now, filter out ones that come in before we are initialized, and
wait for the reset event to start sending things out. This makes sure
that the initialization of setting e.g. `use context current` doesn't
get sent out as an event.
Sometimes we get "empty" resets from VMT, and this commit just filters
those out. But it's not clear when exactly that happens.
- Don't propagate setvalue events; these are coming from page setup, but we want to wait for our 'reset' - Don't setValue at all if the page is “controlled”. Add a new #-parameter #controlled=true that tells the page to not do its usual initialization and instead wait for the reset events - The first 'reset' has a state of '', so deal with that appropriately to handle initialization in events.js
This is a total hack, and should probably be disabled. However, for demo servers it can be incredibly valuable to have share links from e.g. code.pyret.org work. Currently they won't because the Google credentials are wrong. But, we can simply configure these fetches to ask for the corresponding resource on CPO. Consider trying that, then falling back to looking on this server if needed?
(definitionsAtLastRun = false means the program has not been run. We can do one better by setting it to starter2024 and running it)
- Hide and show run/stop on lose/gain control - Make editor and REPL non-editable when losing control - Add event listeners on editor and repl to prompt for control when not in control - Fix a bug where the old REPL contents could be included in the state when it should have been empty just after an interaction
This expects the `fs.exists` message to be present on the embedder to check for file presence. The option is templated in for now, which the extension has control over when it first renders the page. Pages may need to be reloaded for the settings change to take effect. I noticed/remembered while doing this that the CPO file import does not track working directories, this should be fixed by adding to the module finder context just like in cli-module-loader.arr in pyret-lang.
This allows loading from a URL like https://raw.githubusercontent.com/jpolitz/sample-pyret-project/refs/heads/main/lib.arr as starter code. This works even in embedded contexts where the usual storageAPI does not load. It is treated as a “normal” shared file for logged in users, who can save the program (to Drive only) as another name.
url(...) dependency locators for CPO
VScode-in-browser has strict content security policy rules. One of them requires that we serve /editor with certain cross-origin rules (see server.js) I didn't fully tie the knot on making sure that if PYRET is cross-origin (which it is for pyret-horizon!) the requests from preload and dynamic loads check the right header boxes.
…match the MIME (or infer it from extension)
… install errors and they had an update 4.00sInstall deployment dependencies Installing deployment dependencies Installing gem dependencies: nokogiri (~> 1.15), aws-sdk-s3 (~> 1), mime-types (~> 3.4.1) GemWrappers: Can not wrap not executable file: /home/travis/.rvm/gems/ruby-3.3.5/bin/racc.lock GemWrappers: Can not wrap not executable file: /home/travis/.rvm/gems/ruby-3.3.5/bin/racc.lock GemWrappers: Can not wrap not executable file: /home/travis/.rvm/gems/ruby-3.3.5/bin/racc.lock GemWrappers: Can not wrap not executable file: /home/travis/.rvm/gems/ruby-3.3.5/bin/racc.lock You have already activated logger 1.6.0, but your Gemfile requires logger 1.6.6. Since logger is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports logger as a default gem. (Gem::LoadError) failed to deploy https://app.travis-ci.com/github/brownplt/code.pyret.org/builds/274663286#L1246 https://docs.travis-ci.com/user/deployment-v2/providers/heroku/ https://www.travis-ci.com/blog/2019-08-27-deployment-tooling-dpl-v2-preview-release/
By default CPO tries to proxy images through /downloadImg?<url> This allows skipping that entirely (of course, proxying was happening because many servers don't have CORS enabled)
…drive/url-file imports don't report test results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.