Subtle undefined fix #227
Draft
Subtle undefined fix #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoiekim
reviewed
Dec 29, 2023
index.js
Outdated
Comment on lines
93
to
95
| var { Crypto } = require('@peculiar/webcrypto') | ||
| var crypto = new Crypto() | ||
| exports.webcrypto = crypto |
There was a problem hiding this comment.
@peculiar/webcrypto seems not browser compatible as it says in their README:
Module is based on NodeJS v10 Crypto API. It would work only with Node v10 and higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a polyfill for webcrypto, which fixes subtle undefined error.
This pull request contains pull request 215 for fixing the other missing parts.